#126 libxml2-bin overwrites SGML_CATALOG_FILES variable

open
nobody
None
5
2005-01-25
2005-01-25
James Hughes
No

This is a patch for libxml2-bin.

The package init file libxml2-bin.sh exports two
environment variables. Neither of these exports allow
for the fact that those variables might exist, so they
overwrite any extant value of those variables.

This patch just checks to see if the variables exist
and appends the extra path values to the end.

I decided it should append, rather than prepend so the
user can easily override the installed catalog files.
For example, I keep some catalog files in my home
directory which should take precedence. This makes it
easy to keep catalog files up to date without tinkering
in the Fink installation tree.

I would have updated the csh init file too, but I'm not
a csh user so have no way to test easily.

Discussion

  • James Hughes
    James Hughes
    2005-01-25

    Init file from /sw/etc/profile.d/libxml2-bin.sh

     
    Attachments
  • Daniel Macks
    Daniel Macks
    2005-01-26

    Logged In: YES
    user_id=535292

    /sw/bin/init.*, the script that loads /sw/etc/profile.d/* scripts, appear to already supply append_path and prepend_path functions when loading them, sono need to define your own. Keeping with the inherited definition allows fink to supply improved versions of it in the future (and improvements are quite welcome!).

     
  • Max Horn
    Max Horn
    2007-08-26

    Logged In: YES
    user_id=12935
    Originator: NO

    What is the status of this patch?

    I think we should either close it as outdated/won't fix. Or somebody (the originator?) should provide a new updated patch which reflects dmacks' comment.

    Note that one could also assume the stance that those SGML_CATALOG_FILES / XML_CATALOG_FILES vars are "system" env vars, so it's OK for the package to set them to a fixed value. If the user wants to override/modify them, that's fine -- just do it after sourcing Fink's init.*sh script.