#4382 tcpflow-1.4.2


Updated version to tcpflow 1.4.2.

Tested with "fink -m rebuild tcpflow" on 10.9.1/Xcode 5.0.2 (5A3005)

1 Attachments


  • Several issues:

    1. The package uses c++ code, but doesn't have a GCC: 4.0 field to signal this.
    2. Version 1.4.3 came out a few days ago in their github site, and that includes the missing test-subs.sh that was causing the test suite to fail. Can you update to 1.4.3 and readd the InfoTest field if possible?
    3. There is linkage to a large number of other Fink libraries, including, but not limited to cairo, fontconfig, expat, and several others. These will need to be listed in the Depends field (as well as the relevant header package in BuildDepends:).

    My linker line for 1.4.2 looks like this:

    g++ -g -D_THREAD_SAFE -pthread -g -O3 -std=c++11 -Wall -MD -D_FORTIFY_SOURCE=2 -Wpointer-arith -Wshadow -Wwrite-strings -Wcast-align -Wredundant-decls -Wdisabled-optimization -Wfloat-equal -Wmultichar -Wmissing-noreturn -Woverloaded-virtual -Wsign-promo -funit-at-a-time -Weffc++ -L/sw/lib -L/sw/lib -o tcpflow dfxml/src/dfxml_writer.o netviz/plot_view.o netviz/time_histogram_view.o netviz/time_histogram.o netviz/address_histogram_view.o netviz/address_histogram.o netviz/port_histogram_view.o netviz/port_histogram.o netviz/packetfall.o netviz/net_map.o netviz/legend_view.o netviz/one_page_report.o be13_api/beregex.o be13_api/feature_recorder.o be13_api/feature_recorder_set.o be13_api/histogram.o be13_api/pcap_fake.o be13_api/plugin.o be13_api/sbuf.o be13_api/sbuf_stream.o be13_api/unicode_escape.o be13_api/utils.o be13_api/word_and_context_list.o datalink_wifi.o wifipcap/TimeVal.o wifipcap/wifipcap.o wifipcap/cpack.o datalink.o flow.o tcpflow.o tcpip.o tcpdemux.o util.o scan_md5.o scan_http.o scan_tcpdemux.o scan_netviz.o http-parser/http_parser.o mime_map.o -lpcap -lcairo -lfontconfig -lfreetype -lbz2 -lpixman-1 -lexpat -lssl -lcrypto -lz -lssl -lcrypto

    All those '-lfoo' flags at the end need to be accounted for in the Depends: field (or directly

    • Group: Undergoing_Validation --> Awaiting_Update_from_Submitter
  • Coardump

    tcpflow 1.4.3 source package missing file. Working with developer to address it. I'll fix the other issues you noted.

  • Coardump

    Updated to use version 1.4.4 which has a full sourcecode set. .info file fixes implemented.

  • Builds and runs fine on 10.7. Always nice to see responsive upstream.

    Just a few packaging issues:

    1. Is UpdateConfigGuess actually needed? That's usually only needed for old packages whose ./configure scripts don't know about Darwin/OS X. If it is actually needed, please add a note about it to the DescPackaging field so it's not forgotten.
    2. You need to add the matching developer package for all the -shlibs packages listed in the Depends field to the BuildDepends field. This guarantees that the headers (and other compiler files) for the library are present at build time.
    3. system-pkgconfig-libcrypto is not the package you want in order to use the system's openssl. You want "system-openssl-dev" and it goes into BuildDepends. system-pkgconfig-libcrypto only checks for the presence of '/usr/lib/pkgconfig/openssl.pc' but doesn't guarantee that system-openssl will be used by the compiler.
    4. (optional nit) Please put the packages inside the (Build)Depends: fields in alphabetical order. It makes it easier to keep track of what packages are being used (especially if there are changes).
  • Coardump

    Thanks for the feedback.

    • labels: --> Updated Version of Existing
    • status: open --> closed-accepted
    • Group: Awaiting_Update_from_Submitter --> Added_to_Fink