From: Alexander H. <ale...@gm...> - 2014-09-20 22:30:41
|
On 9/20/14, 3:18 PM, Daniel Johnson wrote: > > On Sep 20, 2014, at 7:54 AM, Martin Costabel <cos...@wa...> wrote: > >> On 10/09/14 03:08, Daniel Johnson wrote: >>> I just installed the Xcode 6 GM on 10.9 and things seem ok except for a cosmetic issue. We previously added the flag "-Werror=unused-command-line-argument-hard-error-in-future" to compiler_wrapper because clang started throwing fits at unused compiler flags with clang 5.1. It seems that clang 6.0 no longer cares about this and the -Werror=unused-command-line-argument-hard-error-in-future flag itself is no longer supported. I submitted a pull request which stops adding said option in clang 6 and later here: https://github.com/fink/fink/pull/111. I also simplified the version comparison to only compare the first component of the version number since things like $clang_version > "600.0.0" don't actually work with bash. The ">" only does an ascii comparison and "-gt" only does integer. >>> >>> Please test with older Xcodes to make sure I didn't break anything. >> >> Since Xcode-6 is now released on 10.9, this becomes urgent. Otherwise apt and many other packages will no longer build. >> >> I disagree, however, with your estimate "It seems that clang 6.0 no longer cares about this". What happened in clang 6 is that we have now arrived in the "future" promised by the "hard-error-in-future" part of the older flag. AFAICT, unused command line flags are now errors and can no longer be downgraded to warnings. This means that the easy way out we chose in xcode-5 is no longer available, and all packages that have those unused command line arguments will need to be fixed. I still hope I am wrong, but some little tests really point in this direction. >> >> -- >> Martin >> > > Hmm, it seems you're right. It looks like clang is inconsistent with how it deals with unknown command line options. For example, if I add '-Willegalflag' to a compile line I just get a warning but '-mno-fused-madd' throws an error. Whee! So the future has indeed arrived. I haven't encountered anything that fails to build yet, but we should definitely keep an eye out. > > Daniel > > > fink-0.37.1 includes this change for 10.9/Xcode 6, so we should start getting bug reports for actual unused command line arguments. :-) -- Alexander Hansen, Ph.D. Fink User Liaison My package updates: http://finkakh.wordpress.com/ |