#277 Distinct color warning in right margin

3.0.1
closed-fixed
5
2014-09-21
2012-12-04
Anonymous
No

This is a feature request:
In Eclipse Findbugs displays a bug in the left margin of the code when it has found a bug. You see this when the code is visibible. It would be nice if it could also be displayed in the right margin through a distinct color. Now it is usually yellow allong with all other Eclipse markers so it becomes unclear why a marker is displayed. It could be that Eclipse is complaining about type safety, those reports I want to ignore, but messages generated by FB I would like to see those in an instance and not having to scroll through the code to see if there are any FB warnings. See also screendump for clarity.

Discussion


  • Anonymous
    2012-12-04

    Screen dump to clarify feature

     
    Attachments
  • I do not plan to work on this feature. Feel free to provide a patch.
    Regards,
    Andrey

     
    • labels: 840439 --> Eclipse plugin
    • assigned_to: andyandy --> nobody
     
  • Kevin Lubick
    Kevin Lubick
    2014-09-20

    I have addressed this feature request in https://code.google.com/r/klubick-findbugs/source/list, commits 6643de478407..b886bf3045fd

    Should be pretty easy to verify, 30 lines or so added to plugin.xml

    Attached two pictures to show the new colors (and a standard warning for comparison) and the fact the user can adjust the colors if they want.

     
    • status: open --> open-accepted
    • assigned_to: Andrey Loskutov
    • Group: --> 3.0.1
     
    • status: open-accepted --> closed-fixed
     
  • Thanks Kevin,

    I've pushed the (fixed) patch. The problem was that if e.g. same file would have "of concern" and "scary" warnings, Eclipse editor would show the "green" color in the top right corner, which is at least surprising :-)

    But thanks and please continue with contributing!

    Regards,
    Andrey