#1194 TypeQualifierApplications.getDefaultTypeQualifierAnnotationForParameters should check TypeQualifierDefault of method

2.0.3
closed-fixed
William Pugh
jsr305 (1)
5
2013-09-11
2013-06-30
eller86
No

Hi ALL,
Thanks for your great product, I like it very much and try to learn itself.

Today I found that getDefaultTypeQualifierAnnotationForParameters method of TypeQualifierApplications does not check TypeQualifierDefault of method.

Here is a simple example: https://github.com/eller86/findbugs-plugin/commit/be4f5728ffb646f22423bcda54f592991e54cc34#L3R7

When we execute getDefaultTypeQualifierAnnotationForParameters method to this argument, we expect that this method will return a TypeQualifierAnnotation instance, but it doesn't.

I used attached patch to version 2.0.2, and then it worked. I hope this patch will help you.

1 Attachments

Discussion

    • assigned_to: William Pugh
     
  • Bill,
    The patch looks ok for me. What do you think?
    P.S. I haven't run any tests, just looking at code right now.
    Andrey

     
  • William Pugh
    William Pugh
    2013-09-11

    Added a smaller test case, verified and committed patch

     
  • William Pugh
    William Pugh
    2013-09-11

    • status: open --> closed-fixed
     
  • eller86
    eller86
    2013-09-11

    Thanks for your merging!