From: Jonathan Woithe <jwoithe@ju...> - 2012-09-22 07:06:40
> enclosed a series of patches which might enable coherent mixing/routing
> for Saffire Pro 14 via generic DICE EAP mixer.
Top work, especially since you don't have a pro14 yourself.
> Of course, they are untested (except for compilation) since I have no
> Pro 14 for this. Could you have a thorough look at these, this is the
> first time I really add support for a new device ? Possibly there is
> some additional features to implement I am unaware of.
I've had a look through the patches and they look reasonable to me. Testing
against a real Pro14 may well show up some subtle and not so subtle
problems, but such testing is the only effective way of finding such
problems. I've applied the patch set to trunk as r2223 through to r2229
inclusive which should make it easier for Tim (or other Pro14 owners) to
test and provide feedback. I only made some minor tweaks to the series:
* the multiple compilation protection defines were included in the first
* I added you to the copyright on the new pro14 files
* The order of patch 3 and 4 were swapped so ffado will cleanly compile
at all intermediate stages of the patch series
* commit log messages were editted slightly
> With outputs sent by Tim, I was able to locate the nickname in
> application space of EAP: however, I didn't enable writing, just reading
> so as to await for testing with a Pro 14.
That's fair enough and is a good plan.
In conclusion, FFADO trunk now includes this latest patchset and is ready
for testing (as outlined by yourself) by Tim (and other interested owners of