Le jeudi 10 octobre 2013 à 22:03 +0200, Jano Svitok a écrit :
Hi,

On Thu, Oct 10, 2013 at 7:05 PM, Philippe Carriere <la-page-web-of-phil.contact@orange.fr> wrote:

> Yes, and I am wondering: had you a try changing the setting while streaming ? Of course, it is fundamentally dependent on the firmware
> and possibly the one for Profire polls regularly the register. For the Saffire, no changes are accounted for until the message set register
> is set at the appropriate value.


In this case, it seems it works without message set register. I tested it while streaming, because I wasn't sure if I guessed the bit in app space correctly. I played video in VLC, and checked in headphones whether

the volume knob affects the sound.

So it's nice. Because for Saffire, I was wondering for a long time: first to understand the usefulness of setting this particular register (since it returns to 0x0 immediately after polling, so not easy to detect), then to be sure about the exact value (which depends on the involved setting) to be set. Fortunately, after I finally understood with previous implementation and some tests, I received some informations from Focusrite devel team (for Pro 14 I do not have)  which confirmed the relevance of the whole.

> As an additional comment to the Jonathan remarks, the local variable name "volume" in Profire2626::Profire2626EAP::SettingsSection::SettingsSection()
> is indeed not very explicit: isn't it a switch to connect different outputs to the physical control (and not a value for the volume or anything like),
> which makes the setting very different to the ones for other devices (until now, essentially Saffire) ?

You are right. There's one physical pot, called master volume knob in the manual. It can lower volume of any of the 4 analog output pairs, if the corresponding bits are set.
Otherwise the ports output full volume.

I don't mind changing the volume variable. Is outputPair better? Do you have any better name?

Yes, it appears clearer for me. Possibly Jonathan would have some more comments about this ?

Thank you for the comments and for your saffire the code - with the code it was pretty easy to get this working once I found out the config bits.

Well, I answered rapidly some hours ago since I was busy, but you have yet done a nice work and I think FFADO have a need for new developers. So it is a pleasure to see you contributing.

Jano

Regards,

Phil

--
Philippe Carriere <la-page-web-of-phil.contact@orange.fr>