Hi Roman,

Thanks for your patch. This has now been merged with trunk (SVN Revision 1214).

We gladly accept patches. Generally, submitting them to this list is the fastest way to get them added.

Regards,

Lachlan

Lachlan Kuhn
Senior Web Developer
Library Technology Service
The University of Queensland, Australia
+617 3346 4349

Roman Chyla wrote:
Hi,
I don't know if you accept patches. The batch import for eprints
generates quite a few errors. I have fixed them, in the attachements.

Mainly - the array_push does not add the item if the corresponding
array does not exist, this has had serious consequences of many
missing fiels

minor bugs:
fopen - added tests for success
testing - if the file contents was returned

Please let me know how any future contributions (if you accept them)
can be done. I think that fixing bugs might be more convenient for you
than reporting them.
Best,

  roman

PS: as a consequence of my edits, I deleted one array assignment and
cannot remember which - now, the imported items miss author fileds,
may look into it later

here are the fixed errors:
Warning: array_push(): First argument should be an array in
/var/www/fex/trunk/include/class.batchimport.php on line 290

Warning: array_push(): First argument should be an array in
/var/www/fex/trunk/include/class.batchimport.php on line 267

Warning: array_push(): First argument should be an array in
/var/www/fex/trunk/include/class.batchimport.php on line 290

Warning: array_key_exists(): The second argument should be either an
array or an object in /var/www/fex/trunk/include/class.batchimport.php
on line 149

Warning: fopen(): php_network_getaddresses: getaddrinfo failed: Name
or service not known in
/var/www/fex/trunk/include/class.fedora_api_2_2.php on line 94

Warning:
fopen(http://eprint.yourinst.edu/perl/oai2?verb=GetRecord&metadataPref
ix=oai_dc&identifier=oai%3Aeprint.yourinst.edu.au%3A2): failed to open
stream: Success in /var/www/fex/trunk/include/class.fedora_api_2_2.php
on line 94

Warning: fread(): supplied argument is not a valid stream resource in
/var/www/fex/trunk/include/class.fedora_api_2_2.php on line 97

Warning: fclose(): supplied argument is not a valid stream resource in
/var/www/fex/trunk/include/class.fedora_api_2_2.php on line 100

Warning: DOMDocument::loadXML(): Empty string supplied as input in
/var/www/fex/trunk/include/class.batchimport.php on line 992
Making The Most Of The Web

Warning: array_key_exists(): The second argument should be either an
array or an object in /var/www/fex/trunk/include/class.batchimport.php
on line 149

Warning: array_key_exists(): The second argument should be either an
array or an object in /var/www/fex/trunk/include/class.batchimport.php
on line 149

Warning: fopen(): php_network_getaddresses: getaddrinfo failed: Name
or service not known in
/var/www/fex/trunk/include/class.fedora_api_2_2.php on line 94

Warning:
fopen(http://eprint.yourinst.edu/perl/oai2?verb=GetRecord&metadataPref
ix=oai_dc&identifier=oai%3Aeprint.yourinst.edu.au%3A6): failed to open
stream: Success in /var/www/fex/trunk/include/class.fedora_api_2_2.php
on line 94

Warning: fread(): supplied argument is not a valid stream resource in
/var/www/fex/trunk/include/class.fedora_api_2_2.php on line 97

Warning: fclose(): supplied argument is not a valid stream resource in
/var/www/fex/trunk/include/class.fedora_api_2_2.php on line 100

Warning: DOMDocument::loadXML(): Empty string supplied as input in
/var/www/fex/trunk/include/class.batchimport.php on line 992
The Fewer the Facts, the Stronger the
Opinion
Imported 2 Records

------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

_______________________________________________ Fez-developers mailing list Fez-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fez-developers