#176 exposes too much API

closed-accepted
nobody
None
5
2012-03-01
2012-02-07
Fabian Greffrath
No

Currently, if compiled with GCC under Linux, libfaac.so.0 exposes too much API, i.e. it exposes all the internal symbols, not only those marked FAACAPI. The attached patch sets the appropriate symbol visibility attributes if compiled with GCC-4.x, so all the other symbols could get hidden if compiled with CFLAGS="-fvisibility=hidden". The patch is based on top of my other patch to use the exposed API internally. If applied separately, the line defining FAACAPI must get suplicated in libfaac/frame.h.

Discussion

  • Set appropriate symbol visibility attributes.

     
  • I have changed this patch and commited to CVS.

     
    • status: open --> closed-accepted