#75 Compile fix rollup patch against 2.0.0

closed-fixed
Greg Stein
None
5
2006-12-13
2006-02-24
Mark F. Haigh
No

The attached rollup patch fixes the following bugs:

#1414066 - make failes on hpux

#1033965 - Building application fails with Intel C
compiler (1.95.7)

#N/A - Build fails on Tru64 UNIX.

The patch was tested on x86-64 Linux, i386 NetBSD,
HP-UX 11i, and Tru64 5.1b. All tests passed on each
machine.

Discussion

1 2 > >> (Page 1 of 2)
  • Mark F. Haigh
    Mark F. Haigh
    2006-02-24

    Compile fix rollup patch against 2.0.0

     
    Attachments
  • Mark F. Haigh
    Mark F. Haigh
    2006-02-24

    • assigned_to: nobody --> gstein
     
  • Karl Waclawek
    Karl Waclawek
    2006-02-24

    Logged In: YES
    user_id=290026

    Is this patch against CVS?
    It fails for me on Makefile.in:

    $ patch -i compile-rollup.patch -p 1
    patching file lib/expat_external.h
    patching file Makefile.in
    Hunk #3 succeeded at 157 (offset 1 line).
    Hunk #4 FAILED at 172.
    1 out of 4 hunks FAILED -- saving rejects to file
    Makefile.in.rej
    patching file tests/minicheck.h
    patching file tests/runtests.c

     
  • Mark F. Haigh
    Mark F. Haigh
    2006-02-24

    Logged In: YES
    user_id=1458985

    The patch was against the 2.0.0 release. I'm attaching the
    same patch against CVS as of Feb 23, 2006, 8:00 PST.

     
  • Mark F. Haigh
    Mark F. Haigh
    2006-02-24

    Compile fix rollup patch against CVS as of Feb 23, 2006

     
  • Karl Waclawek
    Karl Waclawek
    2006-02-24

    Logged In: YES
    user_id=290026

    Thanks.
    Seems to work on Cygwin as well.

    Will check it in if Greg has no objections.

     
  • Karl Waclawek
    Karl Waclawek
    2006-02-27

    Logged In: YES
    user_id=290026

    One question about the patch to runtests.c:
    - int callno = 1 + (int)XML_GetUserData(parser);
    + long callno = 1 + (long)XML_GetUserData(parser);

    Why changing from int to long?

    If we really want to be anal, why not change to ptrdiff_t,
    as callno hast to fit into a pointer?

     
  • Karl Waclawek
    Karl Waclawek
    2006-02-27

    Logged In: YES
    user_id=290026

    Actually, it should be uintptr_t or intptr_t, but the
    question is, how many compilers recognize these types (were
    they not introduced with C99?).

     
  • Karl Waclawek
    Karl Waclawek
    2006-03-06

    • status: open --> closed-accepted
     
  • Karl Waclawek
    Karl Waclawek
    2006-03-06

    Logged In: YES
    user_id=290026

    Patch applied March 6, 2006.

     
1 2 > >> (Page 1 of 2)