#504 Crash when XML doesn't have newline at the end

open
Karl Waclawek
None
5
2012-06-13
2012-06-13
Alex
No

Please see this thread
https://bbs.archlinux.org/viewtopic.php?pid=1115372#p1115372
Without newline in XML GoogleEarth crashes, with it - running file. It was suggested in the thread that libexpat is the culprit.

Discussion

  • Alex
    Alex
    2012-06-13

     
    Attachments
  • Karl Waclawek
    Karl Waclawek
    2012-06-13

    • assigned_to: nobody --> kwaclaw
     
  • Karl Waclawek
    Karl Waclawek
    2012-06-13

    Please submit a simple reproducible example that demonstrates the crash.
    I just opened your file (with new line removed) in FireFox, which uses Expat, and had no crash. Also, given that Expat is used i n millions of installations, we would have heard of this earlier. I am inclined to reject this bug report unless I can see a reproducible example.

     
  • Alex
    Alex
    2012-06-13

    Scenario: install GoogleEarth for linux and try to start it, make sure you have .drirc without newline at the end (for me it's crashing on start with error).
    Then add newline at the end of this file and start GoogleEarth again (for me it starts fine).
    On my system (x86_64 linux with lib32-expat installed) it is fully reproducible.
    Feel free to ask for more details if you need to.

     
  • Karl Waclawek
    Karl Waclawek
    2012-06-13

    First: Installing GoogleEarth and running it is not a simple example to demonstrate the bug in Expat.
    Secondly: this example proves nothing, as there are so many components involved that anyone of them could be to blame.
    So many unanswered questions: How is the code written that uses Expat to process the file, is a call-back handler expecting the end of line and crashes because of it, is there some pre or post-processing done on the file, what are the runtime libraries installed, etc. etc.

    Also, the link you mentioned offers a few solutions, some of them simply replacing another Dll with no hint that XML parsing is even involved.

    As I said, a simple example that involves only Expat and some C code is necessary to prove that an XML file without newline at end of file will cause a crash.

     
  • Alex
    Alex
    2012-06-13

    Well, I don't know for sure if this is expat bug. I'm not so familiar with C as to produce scenario that you speak of, this example with GoogleEarth is the best I can do. Do whatever you like with this information, if you think there's nothing to gain from it - throw it out :)