#487 CMake Build system

Feature Request
open-accepted
Karl Waclawek
5
2012-03-05
2010-04-22
SaroEngels
No

I am maintaining the 3rdparty libraries for the KDE Windows port. For this we developed a CMake based build system for expat which is attached. Please have a look and say if you would add it to your repository.
regards,
Patrick

Discussion

  • SaroEngels
    SaroEngels
    2010-04-22

    CMake based build system for expat

     
  • Karl Waclawek
    Karl Waclawek
    2012-03-03

    Seems non-intrusive. If you can update it for current CVS HEAD (release 2.1.0 being prepared), I'll consider it for inclusion.

     
  • Karl Waclawek
    Karl Waclawek
    2012-03-03

    • assigned_to: gstein --> kwaclaw
     
  • Sorry, had a hdd crash yesterday, so I had to use a different username and cannot add files here anymore :-(
    Please download an updated patch from here:
    http://paste.kde.org/~windows/433382/raw/
    I found another person having made a similar patch (in the lua project), but it is essentially the same license & code. I would really love to see this patch upstream, so thank you very much.

     
  • Karl Waclawek
    Karl Waclawek
    2012-03-04

    So, is this all that's needed?

    I know nothing about CMake, so I don't even know if the fact that the make-release.sh script won't include your files in the tar.gz archive matters or not.

    If you need this included there as well, please update the patch accordingly.

    Thanks,

    Karl

     
  • hm, obviously those files need to be distributed as well, I just don't know how to bring the make-release.sh script to include them - I will try that out in a minute.
    I also forgot to add a CMake.README file, so I will update the patch again, but that might have to wait until tomorrow (if that is ok for you).
    Just in general, building with cmake should be as easy as 'mkdir build && cd build && cmake .. && make && make install' (you run the build process in the subdirectory build)

     
  • Karl Waclawek
    Karl Waclawek
    2012-03-04

    The files to include in the distribution archive should be listed in the MANIFEST file. With the standard build not everything is included (for instance, buildconf.sh is not distributed).

     
  • Karl Waclawek
    Karl Waclawek
    2012-03-04

    To make it simple:
    Just e-mail me the new files and the patch to MANIFEST, and I will do the rest in CVS. My e-mail is karl at waclawek.net .

    I assume your files go into the root directory.

     
  • Karl Waclawek
    Karl Waclawek
    2012-03-05

    • status: open --> open-accepted
     
  • Karl Waclawek
    Karl Waclawek
    2012-03-05

    Added CMake build files updated by author to repository. This also satisfies patch submission #3312568.