[Exist-open] [ exist-Patches-2991653 ] Close FileInputStream in AbstractRemoteResource.readFile()

[SourceForge.net <no...@so...>]

Patches item #2991653, was opened at 2010-04-23 22:35
Message generated for change (Tracker Item Submitted) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=317691&aid=2991653&group_id=17691

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: jwalton ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Close FileInputStream in AbstractRemoteResource.readFile()

Initial Comment:
AbstractRemoteFile.readFile(File) does not explicitly close the FileInputStream relying on the JVM finalizer to close the stream. When using the Ant tasks (specifically, xdb:store) to store a large number of files (several thousand) the JVM does not get a chance to call the finalizer before the max open file limit is reached. This is particularly noticeable on Linux when the shell limits the number of open files to 1024.

The supplied patch explicitly closes the FileInputStream preventing the dreaded "Too many open files" error.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=317691&aid=2991653&group_id=17691