From: Stefan S. <st...@no...> - 2007-04-23 21:06:31
|
Claes Wikström <kl...@ta...> wrote: > =ERROR REPORT==== 16-Apr-2007::13:29:42 === > Yaws process died: {{badmatch,{error,emfile}}, > [{yaws_server,deliver_large_file,4}, > {yaws_server,aloop,3}, > {yaws_server,acceptor0,2}, > {proc_lib,init_p,5}]} > > This is a filedescriptor leak. I/We've seen it it before. The bug is still > there and I don't know where the leak is. Don't know if this is good Erlang style or not, but I think it would be better if the file is closed at the place where it gets opened. deliver_large_file/4 opens the file, but gives control (and responsibility to close the file) to send_file/4. I just glimpsed over the code, so maybe I shouldn't ask before checking it by myself: Do the send_file* functions handle broken clients correctly? Regarding ranges? Could be a stupid spider, that hits the site from time to time. -- Web (en): http://www.no-spoon.de/ -*- Web (de): http://www.frell.de/ |