Eric Liang wrote:
> Hi all,
> Last week , I talked about soap on yaws with Steve Vinoski. He
> recommended some valuable articles to read and suggested just using http
> instead of soap. I do agree with him in some aspects, but still can't
> avoid soap. So, it's still necessary to make better support on soap by
> yaws, IMO.
Patch look good to me - some comments.
1. Maybe a good idea to keep soap_srv:start_link/0 if people are
calling this function explicitly - which I think they are.
2. Please add some docs to man/yaws.conf.5 describing how to
use the feature.
I don't like adding stuff to neither gconf nor sconf since these
structs get passed around a lot among processes - i.e copied.
OTOH there is already so much cruft there so adding even more can't harm.
It's time to clean up both these records moving some of the more
exotic features into a subrecord.
So - all in all - nice work, but please comment or fix (1) and do (2)