#84 typo in handling of multiple interrupts

v3.0
closed-fixed
Edward Loper
5
2006-04-04
2006-04-04
Pierre Rouleau
No

Suggestion:

cli.parse_arguments() has a statement that catches the
KeyboardInterrupt and SystemExit exceptions. However,
the syntax uses makes SystemExit the target. No harm
done now, but might as well use the proper syntax
(place the list of interrupt inside an explicit tuple).

Index: cli.py

--- cli.py (revision 1157)
+++ cli.py (working copy)
@@ -213,7 +213,7 @@
if options.configfiles:
try:
parse_configfiles(options.configfiles,
options, names)
- except KeyboardInterrupt,SystemExit: raise
+ except (KeyboardInterrupt, SystemExit): raise
except Exception, e:
optparser.error('Error reading config
file:\n %s' % e)

Discussion

  • Edward Loper
    Edward Loper
    2006-04-04

    Logged In: YES
    user_id=195958

    Fixed in subversion revision 1158

     
  • Edward Loper
    Edward Loper
    2006-04-04

    • status: open --> closed-fixed