From: David S. <on...@gm...> - 2012-11-19 14:31:41
|
On Mon, 19 Nov 2012 12:22:18 -0200 Lucas De Marchi <luc...@pr...> wrote: > On Mon, Nov 19, 2012 at 11:22 AM, Stefan Schmidt > <s.s...@sa...> wrote: > > Hello. > > > > On 19/11/12 13:10, Enlightenment SVN wrote: > >> Log: > >> evas: Fix shadow warnings > >> > >> x1, x2 shadow something in the math library. > >> > >> Would probably be better to turn off -Wshadow, but for some > >> reason people think this there's some value in it... > > > > I agree that the x1, x2, y1, etc warnings from the math lib are > > annoying. Sometimes the shadow warnings show problematic code > > though. > > > > I'm open for suggesting what warning flags we want to have as > > default for buildbot. If people agree (I know there is no such > > thing as universal agreement here on the list) that we should just > > skip -Wshadow I'm fine with changing the buildbot builds that way. > > > Use a compile that works fine with that option? There's no reason for > a compiler to throw a warning if a variable named "x2" shadows a > function or another entity. gcc >= 4.7 seems to get this right (I'm > not sure which exactly version that became true, but I think it's gcc > 4.7 indeed). > > Related rant from Linus back in 2006: > https://lkml.org/lkml/2006/11/28/239 I fully agree with Linus on that. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. |