From: ChunEon P. <he...@na...> - 2012-10-30 02:15:23
|
Concept looks good to me. But here are few comments. 1. please make deprecated apis use new apis. i.e elm_notify_orient_set() { //... elm_notify_align_set() } 2. rather than EVAS_HINT_FILL, it will be better if it provides notify defintion. i.e #define ELM_NOTIFY_ALIGN_FILL -1.0 because that elm_notify_align_set API is not for Evas but Elm. and it will be better if API doc mention about using ELM_NOTIFY_ALIGN_FILL . Anything else good to me. Thank you. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Seunggyun Kim"<sgy...@sa...> To: "'ChunEon Park'"<he...@na...>; "'Enlightenment developer list'"<enl...@li...>; "'Daniel Juyung Seo'"<seo...@gm...>; Cc: <sgy...@sa...>; Sent: 2012-10-25 (목) 23:59:32 Subject: RE: [E-devel] [Patch] Align of Elm_Notify I attached new patch. The old patch's default position and mirroring problem has been fixed. I added new 2 APIs for supporting various notify's postion. EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_notify_align_get(const Evas_Object *obj, double *horizontal, double *vertical); And below 2 APIs will be deprecated. EINA_DEPRECATED EAPI void elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient); EINA_DEPRECATED EAPI Elm_Notify_Orient elm_notify_orient_get(const Evas_Object *obj); Please review this patch. Thanks:) -----Original Message----- From: ChunEon Park [mailto:he...@na...] Sent: Tuesday, October 23, 2012 4:49 PM To: Enlightenment developer list; 'Daniel Juyung Seo' Cc: sgy...@sa... Subject: Re: [E-devel] [Patch] Align of Elm_Notify +1 elm_notify_orient_set(Evas_Object *obj, double *x, double *y) in elm 2.0 or elm_notify_align_set(Evas_Object *obj, double *x, double *y) To determine it's size and position (in relative case) we can refer the size_hints values. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Seunggyun Kim"<sgyun.kim>@samsung.com> To: "'Daniel Juyung Seo'"<seojuyung2>@gmail.com>; "'Enlightenment developer list'"<enlightenment-devel>@lists.sourceforge.net>; Cc: <sgyun.kim>@samsung.com>; Sent: 2012-10-23 (화) 16:38:01 Subject: Re: [E-devel] [Patch] Align of Elm_Notify Hello, Thanks for reviewing. Actually, there are two option for resolving issues you comment. First option is to use elm_notify_orient_set api instead of evas_object_size_hint_align_set. But that api's arguments have to be changed like below prototype. - before elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient) - after elm_notify_orient_set(Evas_Object *obj, double *x, double *y) however this changing will occur compatibility problem. Second option is to add new API like below. elm_notify_align_set(Evas_Object *obj, double *x, double *y) I'm not sure which one is the best solution. At that time I made patch, I consider the window object that added by elm_notify is parent object. And I think elm_notify has the window's child relation. So I think elm_notify also can be controled by evas_object_size_hint_align_set. Anyway, I have a question about general alignment cases. Which objects can use these evas_object_size_hint_align_set and evas_object_size_hint_weight_set apis? (box, table??) I think efl developers are little comfusing about that. Can anyone answer this? I'll send new patch after this issue is cleared. Thanks. -----Original Message----- From: Daniel Juyung Seo [mailto:seo...@gm...] Sent: Tuesday, October 23, 2012 3:02 PM To: Enlightenment developer list Cc: sgy...@sa... Subject: Re: [E-devel] [Patch] Align of Elm_Notify Hello, I don't know if we can use this size hints stuffs to this kind of general alignment cases. But I have some other comments. 1. default behavior is broken Default position is top but it's now broken. Because 0.5 is the default value of align hints. You can easily reproduce this by removing the following line from test_notify.c in your patch. > evas_object_size_hint_align_set(notify, 0.5, 0.0); 2. mirroring Mirroring is broken. Test it by enalbing UI-Mirroring option of elementary_test. It's broken. Daniel Juyung Seo (SeoZ) On Mon, Oct 22, 2012 at 5:10 PM, Seunggyun Kim <sgyun.kim>@samsung.com> wrote: > Hi. > > I attached elm_notify's patch supporting hint align set. > Current elm_notify's position has being controlled only by > elm_notify_orient_set API . > This API are supporting 9 direction and showing only child's min size's > layout. > > So I made elm_notify patch for supporting various GUI scenarios. > > Changed feature are like below. > - support moving to any position using x,y align value. > - support expanding child's layout to parent's size. > > Notify can be moved and expanped by using evas_object_size_hint_set. > For example, > evas_object_size_hint_align_set(notify, 0.0 0.0); // > ELM_NOTIFY_ORIENT_TOP_LEFT > evas_object_size_hint_align_set(notify, 0.5 0.5); // > ELM_NOTIFY_ORIENT_CENTER > evas_object_size_hint_align_set(notify, 1.0 1.0); // > ELM_NOTIFY_ORIENT_BOTTOM_RIGHT > evas_object_size_hint_align_set(notify, EVAS_HINT_FILL, 1.0); // fill > bottom area > > I think elm_notify_orient_set isn't necessary anymore. > But for compatibility, I remained the API and that still can be used. > > I attached elm_notify.c and test_notify.c diff. > Please review my patch. > Thanks :) > > ---------------------------------------------------------------------------- -- > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_sfd2d_oct > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ enlightenment-devel mailing list enl...@li... https://lists.sourceforge.net/lists/listinfo/enlightenment-devel |