Re: [E-devel] [patch][elementary] add reorder fast mode for mobile case

[Daniel J. S. <seo...@gm...>]

Good catch :)
In svn but I fixed some of you codes.
Please read this carefully.

1. removed _viewport_coord_get function from your patch.
The function is not needed in this scenario.
So I just removed it and calculated geometry directly.

2. line wrap
Do not exceed 80 chars per line.
I fixed it.

3. local variable declarations at the start of each function
Declare local variables at the start of each function.
I fixed it.

Thanks otherwise.

Daniel Juyung Seo (SeoZ)

On Mon, Oct 1, 2012 at 4:51 PM, Bluezery <oh...@gm...> wrote:
> Sorry, test code was in there  :(
> I removed them.
>
>
> 2012/10/1 Daniel Juyung Seo <seo...@gm...>:
>> It looks like there are unnecessary codes in your patch.
>> Can you please resend the patch?
>>
>> Daniel Juyung Seo (SeoZ)
>>
>> On Fri, Sep 28, 2012 at 10:04 PM, Bluezery <oh...@gm...> wrote:
>>> Dear EFL developers,
>>>
>>> In current genlist reorder mode, reordering is not moved when
>>> reordering item is on top or in bottom of within genlist objec because
>>> of scroller's hold mode.
>>> After mouse point is moved out of genlist object, then reordering item
>>> can be moved.
>>> But in mobile, mouse point can not be moved out of window (if genlist
>>> item is expanded in window).
>>> So I add some tweaks to reordering item can be moved when reordering
>>> item is moved on top item or bottom item.
>>>
>>> Please review this patch.
>>>
>>> BRs
>>> Kim.
>>>
>>> --
>>> BRs,
>>> Kim.
>>>
>>> ------------------------------------------------------------------------------
>>> Got visibility?
>>> Most devs has no idea what their production app looks like.
>>> Find out how fast your code is with AppDynamics Lite.
>>> http://ad.doubleclick.net/clk;262219671;13503038;y?
>>> http://info.appdynamics.com/FreeJavaPerformanceDownload.html
>>> _______________________________________________
>>> enlightenment-devel mailing list
>>> enl...@li...
>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>>
>>
>> ------------------------------------------------------------------------------
>> Got visibility?
>> Most devs has no idea what their production app looks like.
>> Find out how fast your code is with AppDynamics Lite.
>> http://ad.doubleclick.net/clk;262219671;13503038;y?
>> http://info.appdynamics.com/FreeJavaPerformanceDownload.html
>> _______________________________________________
>> enlightenment-devel mailing list
>> enl...@li...
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
>
> --
> BRs,
> Kim.