Re: [E-devel] [PATCH] fix build warning in scim-immodule

[Daniel J. S. <seo...@gm...>]

+1 here.
He's been sending many patches so far and done a good job mainly on ecore imf.

Daniel Juyung Seo (SeoZ)

On Tue, Dec 27, 2011 at 11:28 PM, Cedric BAIL <ced...@fr...> wrote:
> On Tue, Dec 27, 2011 at 3:13 PM, Iván Briano (Sachiel)
> <sac...@gm...> wrote:
>> 2011/12/27 Jihoon Kim <imf...@gm...>:
>>> Here are two simple patches.
>>>
>>> 'fix_warning_scim_imcontext.patch' is for fixing build warning 'warning:
>>> unused parameter' in scim-immodule.
>>> 'fix_indent_Makefile.patch' is for fixing indentation of Makefile.am in
>>> immodules/scim directory.
>>>
>>> Would you please apply in svn?
>>
>> In, both at once. I changed the warning fix to include config.h
>> at the top, as that's what we do everywhere else.
>>
>> I'm also wondering if your next patch shouldn't be an info.txt file
>> and your public key.
>
> Sounds like a lazy way to get the work done faster and better as
> Jihoon has been annoyingly sending patch that get in svn quite fast
> since sometimes now. So I vote that we get less work and put the
> burden on him by giving him svn access.
> --
> Cedric BAIL
>
> ------------------------------------------------------------------------------
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> http://p.sf.net/sfu/intel-appdev
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel