Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas

[Carsten H. (T. R. <ra...@ra...>]

On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo <seo...@gm...>
said:

i see my test worked. the irrational formatting pedants now come out of the
woodwork. i did this to see just who would respond and how.

i added spaces on BLANK LINES that align with indenting. all it takes is an
enter or hitting tab. all editors do this by default (with autoindent on).

are these pedants (like you and vincent) proposing that we fight against our
editors and keep undoing the work they do for us? i assume the answer is yes
because this whole thing is irrational.

> Well... This is my personal opinion about this commit.
> This is so disappointing and childish as a grown-up person.
> 
> I didn't set that vim configuration before I was requested to remove
> trailing whitespaces from enlightenment community.
> Now e-founder encourages trailing whitespaces.
> Seriously that's so funny.
> 
> Anyhow, I have no objection to you doing this funny behavior because
> it looks like trailing whitespace is now allowed in enlightenment.
> 
> Thanks.
> 
> Daniel Juyung Seo (SeoZ)
> 
> On Sun, Oct 23, 2011 at 12:51 PM, Enlightenment SVN
> <no-...@en...> wrote:
> > Log:
> > annoy vim users with spaces at the start of blank lines. :)
> >
> >
> >
> > Author:       raster
> > Date:         2011-10-22 20:51:41 -0700 (Sat, 22 Oct 2011)
> > New Revision: 64317
> > Trac:         http://trac.enlightenment.org/e/changeset/64317
> >
> > Modified:
> >  trunk/evas/src/lib/canvas/evas_async_events.c
> >
> > Modified: trunk/evas/src/lib/canvas/evas_async_events.c
> > ===================================================================
> > --- trunk/evas/src/lib/canvas/evas_async_events.c       2011-10-22 23:40:48
> > UTC (rev 64316) +++ trunk/evas/src/lib/canvas/evas_async_events.c
> > 2011-10-23 03:51:41 UTC (rev 64317) @@ -3,11 +3,11 @@
> >
> >  #ifdef BUILD_ASYNC_EVENTS
> >
> > -#ifndef _MSC_VER
> > -# include <unistd.h>
> > -#endif
> > -#include <fcntl.h>
> > -#include <errno.h>
> > +# ifndef _MSC_VER
> > +#  include <unistd.h>
> > +# endif
> > +# include <fcntl.h>
> > +# include <errno.h>
> >
> >  static int _fd_write = -1;
> >  static int _fd_read = -1;
> > @@ -28,21 +28,21 @@
> >  evas_async_events_init(void)
> >  {
> >    int filedes[2];
> > -
> > +
> >    _init_evas_event++;
> >    if (_init_evas_event > 1) return _init_evas_event;
> > -
> > +
> >    if (pipe(filedes) == -1)
> >      {
> >        _init_evas_event = 0;
> >        return 0;
> >      }
> > -
> > +
> >    _fd_read = filedes[0];
> >    _fd_write = filedes[1];
> > -
> > +
> >    fcntl(_fd_read, F_SETFL, O_NONBLOCK);
> > -
> > +
> >    return _init_evas_event;
> >  }
> >
> > @@ -51,12 +51,12 @@
> >  {
> >    _init_evas_event--;
> >    if (_init_evas_event > 0) return _init_evas_event;
> > -
> > +
> >    close(_fd_read);
> >    close(_fd_write);
> >    _fd_read = -1;
> >    _fd_write = -1;
> > -
> > +
> >    return _init_evas_event;
> >  }
> >
> > @@ -79,10 +79,10 @@
> >    Evas_Event_Async *ev;
> >    int check;
> >    int count = 0;
> > -
> > +
> >    if (_fd_read == -1) return 0;
> > -
> > -   do
> > +
> > +   do
> >      {
> >        check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
> >
> > @@ -92,11 +92,11 @@
> >             free(ev);
> >             count++;
> >          }
> > -     }
> > +     }
> >    while (check > 0);
> > -
> > +
> >    evas_cache_image_wakeup();
> > -
> > +
> >    if (check < 0)
> >      {
> >         switch (errno)
> > @@ -108,7 +108,7 @@
> >              _fd_read = -1;
> >           }
> >      }
> > -
> > +
> >    return count;
> >  #else
> >    return 0;
> > @@ -122,27 +122,27 @@
> >    Evas_Event_Async *ev;
> >    ssize_t check;
> >    Eina_Bool result = EINA_FALSE;
> > -
> > +
> >    if (!func) return 0;
> >    if (_fd_write == -1) return 0;
> > -
> > +
> >    ev = calloc(1, sizeof (Evas_Event_Async));
> >    if (!ev) return 0;
> > -
> > +
> >    ev->func = func;
> >    ev->target = target;
> >    ev->type = type;
> >    ev->event_info = event_info;
> > -
> > -   do
> > +
> > +   do
> >      {
> >         check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> >      }
> > -   while ((check != sizeof (Evas_Event_Async*)) &&
> > +   while ((check != sizeof (Evas_Event_Async*)) &&
> >           ((errno == EINTR) || (errno == EAGAIN)));
> > -
> > +
> >    evas_cache_image_wakeup();
> > -
> > +
> >    if (check == sizeof (Evas_Event_Async*))
> >      result = EINA_TRUE;
> >    else
> > @@ -156,7 +156,7 @@
> >              _fd_write = -1;
> >           }
> >      }
> > -
> > +
> >    return result;
> >  #else
> >    func(target, type, event_info);
> >
> >
> > ------------------------------------------------------------------------------
> > The demand for IT networking professionals continues to grow, and the
> > demand for specialized networking skills is growing even more rapidly.
> > Take a complimentary Learning@Cisco Self-Assessment and learn
> > about Cisco certifications, training, and career opportunities.
> > http://p.sf.net/sfu/cisco-dev2dev
> > _______________________________________________
> > enlightenment-svn mailing list
> > enl...@li...
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
> 
> ------------------------------------------------------------------------------
> The demand for IT networking professionals continues to grow, and the
> demand for specialized networking skills is growing even more rapidly.
> Take a complimentary Learning@Cisco Self-Assessment and learn 
> about Cisco certifications, training, and career opportunities. 
> http://p.sf.net/sfu/cisco-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ra...@ra...