Re: [E-devel] Division by zero at lib Elementary

[Dave A. <da...@gu...>]

2010/11/10 Rafael Fonseca <rfo...@pr...>:
>> elm_gengrid_item_size_set is called in the code, but the value is
>> calculated depending on the size of the container. When I add items in
>> it, the first time the container objet is 0x0. After that the
>> container is resized, the signal resized is sent and the value of
>> imte_size_set is calculated to always have the same number of rows.
>
> As I thought. It should be or a missing size_set call or the size_set
> was depending on something that was returning 0.
>
>> but IMO we should check values before dividing.
>
> Completely agreed.
>
> The only problem I thought of was that if the error was triggered by a
> missing size_set call and we just added the checkers for 0, the user
> would have no clue why his items were not being displayed (Aren't they
> being created? Are they being wrongly positioned outside viewport area?).
>
> Maybe a good solution is besides adding the checkers also print an error
> message in the case of an item of dimension 0x0. Is that good enough?

yeah, this is one of the bugs spotted by the elm_gengrid.py test I have done
some weeks ago (while writing gengrind python bindings).
IMO we should:
- check for 0 sizes before calcs
- write a warning in case of 0 sizes
- AND create the object with a size default different than 0,0
when I start playing with gengrid it took 2 hours to understand that I need
to explicit give a size!!

Nicolas: (hallo!!) also with all this checking implemented you should
check in you
size callbacks if sizes are not 0 before using gengrid_item_size_set()

DaveMDS

>
> --
> Rafael Fonseca
> ProFUSION embedded systems
> http://www.profusion.mobi
>
> ------------------------------------------------------------------------------
> The Next 800 Companies to Lead America's Growth: New Video Whitepaper
> David G. Thomson, author of the best-selling book "Blueprint to a
> Billion" shares his insights and actions to help propel your
> business during the next growth cycle. Listen Now!
> http://p.sf.net/sfu/SAP-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>