Re: [E-devel] Bugfix for screenshot module

[Andreas V. <li...@br...>]

Am Sun, 14 Dec 2008 12:21:54 -0500 schrieb Christopher Michael:

Do you propose the replace the default theme of your screenshot
module? Don't you like your current default? I could also provide it as
external theme in exchange.

regards
Andreas

> Andreas,
> 
> Thanks :) After getting those files manually, it works fine as the 
> default module theme if you want to commit it, that's fine with me :)
> 
> Thanks,
> devilhorns
> 
> Andreas Volz wrote:
> > Am Sun, 14 Dec 2008 11:57:52 -0500 schrieb Christopher Michael:
> > 
> > Hello Christoper,
> > 
> > I copied it to ~/.e/e/themes/ and choosed it with the E theme
> > chooser instead of the default one. I could also decompress it with
> > edje_decc. Maybe you should download it again. Anyway, I uploaded
> > the source:
> > 
> > http://tux-style.de/linux/themes/e-module-screenshot-digital/src/
> > 
> > regards
> > Andreas
> > 
> >> Thanks for checking with me before you did the commit :)
> >>
> >> The code patch looks fine, that can go in, However the new edj does
> >> not work by default with the screenshot module. When I copied the
> >> new edj in place of the old one, the module basically disappeared
> >> from the shelf. Also, for some reason, the edj file cannot be
> >> decompressed with edje_decc, it just spits out an error. Can you
> >> provide the edc so I can see what's going on there ?
> >>
> >> Thanks,
> >> devilhorns
> >>
> >> Andreas Volz wrote:
> >>> Hello Christopher,
> >>>
> >>> I fixed two problems in the E17 screenshot module:
> >>>
> >>> 1. The aspect of the edje theme was fixed to a special size.
> >>>
> >>> 2. If you change timer config while active count it could get
> >>> negative.
> >>>
> >>> For both problems I provide this patch:
> >>>
> >>> http://tux-style.de/linux/enlightenment/patches/screenshot_module/e_screenshot_module_counter_bug_and_aspect.patch
> >>>
> >>> The reason to fix 1. was that I liked to create a digital camera.
> >>> See this edj file: (not yet finished; e.g. the flash)
> >>>
> >>> http://tux-style.de/linux/themes/e-module-screenshot-digital/e-module-screenshot.edj
> >>>
> >>> Here a screenshot:
> >>>
> >>> http://tux-style.de/linux/enlightenment/patches/screenshot_module/2008-12-14-131312.png
> >>>
> >>> I could apply the patch because I've commit right. But I don't
> >>> like to do that before you confirm.
> >>>
> >>> regards
> >>> Andreas
>