From: Tilman S. <ti...@co...> - 2007-03-29 18:39:07
|
Cedric BAIL [2007-03-29 17:58]: > Another little patch that potentially break every thing and need review. To > make the story short, when you have a lot of image on the screen with many > cliping, you are creating and destroying many time Cutout_Rect object. So I > changed the code to do less allocation/destruction. It also break the API > used by the engine, so a patch for them is needed. Looks good in general. I attached a modified version of your patch where I removed some oddities: In evas_common_draw_context_cutouts_del(), I renamed "delta" to "index". "delta" implies (for me) that it's the difference between two values, but it really is an index ;) I also removed some unrelated changes that crept into the patch, like that "error_data" enum that wasn't referenced anywhere, and a few whitespace-only changes. Not sure whether I'm brave enough to commit this :) Regards, Tilman -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on usenet and in e-mail? |