From: Dave Andreoli <dave@gu...> - 2011-01-28 08:10:30
2011/1/28 Enlightenment SVN <no-reply@...>:
> fix documentation so vtorri can write a correct example :)
I also made the example with the wrong return value, the reason
for the error is that this callback is not consistent with the rest of
the API, you should use the define:
ECORE_CALLBACK_RENEW = EINA_TRUE
ECORE_CALLBACK_CANCEL = EINA_FALSE
but they are wrong for this callback :(
maybe we should add 2 new define ??
ECORE_DOWNLOAD_CONTINUE = 0
ECORE_DOWNLOAD_ABORT = 1
Also the doc say that the status param of the complete_cb
(that is an int) shoud contain the http error:
from the doc: "status will be filled with the status of the download
I never see the function return nothing different from 0 or 1, is
the doc wrong?
> Author: raster
> Date: 2011-01-27 19:00:48 -0800 (Thu, 27 Jan 2011)
> New Revision: 56340
> Trac: http://trac.enlightenment.org/e/changeset/56340
> Modified: trunk/ecore/src/lib/ecore_file/ecore_file_download.c
> --- trunk/ecore/src/lib/ecore_file/ecore_file_download.c 2011-01-28 02:46:27 UTC (rev 56339)
> +++ trunk/ecore/src/lib/ecore_file/ecore_file_download.c 2011-01-28 03:00:48 UTC (rev 56340)
> @@ -104,12 +104,13 @@
> * will be filled with the status of the download (200, 404,...). The
> * @p progress_cb is called during the download operation, each time a
> * packet is received or when CURL wants. It can be used to display the
> - * percentage of the downloaded file. The only operations that can be
> - * aborted are those with protocol 'http' or 'ftp'. In that case @p job_ret
> - * can be filled. It can be used with ecore_file_download_abort() or
> - * ecore_file_download_abort_all() to respectively abort one or all
> - * download operations. This function returns EINA_TRUE if the
> - * download starts, EINA_FALSE otherwise.
> + * percentage of the downloaded file. Return 0 from this callback if provided
> + * to continue the operation or anything else to abort the download. The only
> + * operations that can be aborted are those with protocol 'http' or 'ftp'. In
> + * that case @p job_ret can be filled. It can be used with
> + * ecore_file_download_abort() or ecore_file_download_abort_all() to
> + * respectively abort one or all download operations. This function returns
> + * EINA_TRUE if the download starts, EINA_FALSE otherwise.
> EAPI Eina_Bool
> ecore_file_download(const char *url,
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> enlightenment-svn mailing list