Just Launched: You can now import projects and releases from Google Code onto SourceForge
We are excited to release new functionality to enable a 1-click import from Google Code onto the Allura platform on SourceForge. You can import tickets, wikis, source, releases, and more with a few simple steps. Read More
From: Christopher Michael <cpmichael1@co...> - 2009-07-20 02:53:36
Gustavo Sverzut Barbieri wrote:
> On Sun, Jul 19, 2009 at 5:08 PM, Enlightenment
> SVN<no-reply@...> wrote:
>> Cleanup compiler warning on e_signals.c:
>> execinfo.h (which contains the backtrace* functions is only included
>> if OBJECT_PARANOIA_CHECK is defined so add an #ifdef around those calls.
> no, this has nothing to do with object paranoia. These changes were
> meant to help us with user problems. Include execinfo.h always and
> remove the ifdefs.
I understand the reason of helping with user problems, but according to
the code, execinfo.h is only included if OBJECT_PARANOIA_CHECK is enabled:
so in a way it DOES have something to do with OBJECT_PARANOIA_CHECK in
that the execinfo.h header was not added if paranoia_check was not
defined...leading to the compiler complaining about missing
functions...thus the reason why I added an #ifdef OBJECT_PARANOIA_CHECK
around the backtrace code.
NOW, having said that, if it is the general "wish" of the E 'Team' to
always include the backtrace code (even for a 'release'), then by all
means I will remove the #ifdef OBJECT_PARANOIA_CHECK around the
backtrace calls (which I added to fix the compiler warning) and just
include <execinfo.h> regardless...but IMO this may not be desirable in
the long term because most 'average users' would not know what to do
with the backtrace anyway.