From: Vincent T. <vt...@un...> - 2008-07-17 18:55:05
|
Hey, in eet_data.c, in _eet_free_hash() : long int ptr = (long int)(data); hash ^= ptr >> 32; and the others long int is 32 bits long on 32 bits computers. Is it possible that a problem can arise, here ? Vincent |
From: Peter W. <pet...@we...> - 2008-07-17 20:35:18
|
Vincent Torri schrieb: > Hey, > > in eet_data.c, in _eet_free_hash() : > > long int ptr = (long int)(data); > > hash ^= ptr >> 32; > and the others > > long int is 32 bits long on 32 bits computers. Is it possible that a > problem can arise, here ? > Right, that produces a warning. I fixed that (hopefully right) and some other compile warnings in eet_data.c. There are still some warnings in eet_lib.c and eet_iamge.c eet_lib.c: In function 'eet_internal_read2': eet_lib.c:856: warning: comparison between signed and unsigned eet_lib.c: In function 'eet_internal_read1': eet_lib.c:949: warning: comparison between signed and unsigned eet_lib.c: In function 'eet_internal_read': eet_lib.c:1083: warning: comparison between signed and unsigned eet_lib.c: In function 'eet_open': eet_lib.c:1182: warning: comparison between signed and unsigned eet_image.c: In function 'eet_data_image_jpeg_rgb_decode': eet_image.c:234: warning: comparison between signed and unsigned eet_image.c:238: warning: comparison between signed and unsigned eet_image.c:241: warning: comparison between signed and unsigned eet_image.c:241: warning: comparison between signed and unsigned eet_image.c:245: warning: comparison between signed and unsigned eet_image.c:249: warning: comparison between signed and unsigned eet_image.c:270: warning: comparison between signed and unsigned eet_image.c:274: warning: comparison between signed and unsigned eet_image.c:277: warning: comparison between signed and unsigned eet_image.c:277: warning: comparison between signed and unsigned eet_image.c:281: warning: comparison between signed and unsigned eet_image.c:285: warning: comparison between signed and unsigned eet_image.c: In function 'eet_data_image_jpeg_alpha_decode': eet_image.c:376: warning: comparison between signed and unsigned eet_image.c:380: warning: comparison between signed and unsigned eet_image.c:383: warning: comparison between signed and unsigned eet_image.c:383: warning: comparison between signed and unsigned eet_image.c:387: warning: comparison between signed and unsigned eet_image.c:391: warning: comparison between signed and unsigned |
From: Carsten H. (T. R. <ra...@ra...> - 2008-07-26 14:08:00
|
On Thu, 17 Jul 2008 22:35:08 +0200 Peter Wehrfritz <pet...@we...> babbled: it should be unsigned long - this will then match the size of void *. changed in cvs. > Vincent Torri schrieb: > > Hey, > > > > in eet_data.c, in _eet_free_hash() : > > > > long int ptr = (long int)(data); > > > > hash ^= ptr >> 32; > > and the others > > > > long int is 32 bits long on 32 bits computers. Is it possible that a > > problem can arise, here ? > > > Right, that produces a warning. I fixed that (hopefully right) and some > other compile warnings in eet_data.c. There are still some warnings in > eet_lib.c and eet_iamge.c > > eet_lib.c: In function 'eet_internal_read2': > eet_lib.c:856: warning: comparison between signed and unsigned > eet_lib.c: In function 'eet_internal_read1': > eet_lib.c:949: warning: comparison between signed and unsigned > eet_lib.c: In function 'eet_internal_read': > eet_lib.c:1083: warning: comparison between signed and unsigned > eet_lib.c: In function 'eet_open': > eet_lib.c:1182: warning: comparison between signed and unsigned > eet_image.c: In function 'eet_data_image_jpeg_rgb_decode': > eet_image.c:234: warning: comparison between signed and unsigned > eet_image.c:238: warning: comparison between signed and unsigned > eet_image.c:241: warning: comparison between signed and unsigned > eet_image.c:241: warning: comparison between signed and unsigned > eet_image.c:245: warning: comparison between signed and unsigned > eet_image.c:249: warning: comparison between signed and unsigned > eet_image.c:270: warning: comparison between signed and unsigned > eet_image.c:274: warning: comparison between signed and unsigned > eet_image.c:277: warning: comparison between signed and unsigned > eet_image.c:277: warning: comparison between signed and unsigned > eet_image.c:281: warning: comparison between signed and unsigned > eet_image.c:285: warning: comparison between signed and unsigned > eet_image.c: In function 'eet_data_image_jpeg_alpha_decode': > eet_image.c:376: warning: comparison between signed and unsigned > eet_image.c:380: warning: comparison between signed and unsigned > eet_image.c:383: warning: comparison between signed and unsigned > eet_image.c:383: warning: comparison between signed and unsigned > eet_image.c:387: warning: comparison between signed and unsigned > eet_image.c:391: warning: comparison between signed and unsigned > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |