#346 False edge trigger on edge.comp when input is initially high.

2.5.next
closed-fixed
Chris Radek
edge (1)
1
2014-04-10
2013-12-21
Frank Tkalcevic
No

The edge component, edge.comp, starts with the last input value (last_in) 0, so if you start the component, and the input is already 1, you will get a false edge trigger.

It needs a "first" variable, to assign the last_in variable the first time the function is run.

This is a simple fix, but the version I'm running doesn't match what is in master, so I wasn't able to test against master.

Discussion

  • Frank post your proposed change here and I will apply it to the latest code and submit.

     
  • Frank have you tested this in 2.6 master recently?

     
  • No, sorry. The change is pretty simple. Just make sure the first time though, just load the values and don't trigger.

     
    Last edit: Frank Tkalcevic 2014-04-03
  • I made the suggested change and attached the code. Frank, can you please verify that it is correct.

     
    Attachments
  • The change looks correct.

     
  • Chris Radek
    Chris Radek
    2014-04-10

    Thanks for this fix, Frank. It will be in 2.5.4 and later versions.

     
  • Chris Radek
    Chris Radek
    2014-04-10

    • status: open --> closed-fixed
    • assigned_to: Chris Radek
    • Group: 2.6 --> 2.5.next