#305 PNCCONF spindle-at-speed-led always red

2.6
closed-fixed
nobody
None
5
2014-01-21
2012-12-03
Scott Hasse
No

After using pncconf to create a configuration including the pyvcp spindle speed meter and having encoder feedback enabled, the "spindle at speed" LED is always red. The actual spindle at speed signal is accurate within the parameters configured, but a mapping is missing from the pyvcp_options.hal.

I believe this is due to an indentation issue around line 3308 of pncconf.py. The if..else conditional is I believe only supposed to apply to the pyvcp.spindle-speed mapping, but it is applying to the spindle-at-speed and comment lines as well, preventing those from being written in the spindle_enc true case.

A patch file is attached.

Discussion

  • Chris M
    Chris M
    2012-12-18

    This has been fixed -> Thanks for report / fix!
    Chris M

     
  • Chris M
    Chris M
    2014-01-21

    • status: open --> closed-fixed
    • Group: --> 2.6