Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#232 Unused variable warnings in defmethod

HEAD
closed
nobody
None
1
2014-09-23
2012-12-17
stassats
No

(defmethod a-method ((x t))
1)
complains about x being unused, but it's used for specializing. All other implementations don't signal warnings in such case, and some signal only when the lambda expression is just (x).

So, I'd argue that ECL should not signal a warning in ((x specializer)) case, because it's a common practice and many programs assume it, which results in a lot of irrelevant warnings when compiling with ECL.

Another issue with this is that when that warning is signaled, it's printed as
;;; Warning:
;;; in file ...

But it's not a full warning, just a style-warning, so printing "Style-warning:" instead would be less confusing.

Discussion

  • Thanks for your hint. Your reports are really helpful in improving usability!

    I just uploaded two patches. One changes DEFMETHOD's lambda forms to declare ignorable the required arguments. The second one changes a couple of warnings into style warnings.

     


Anonymous


Cancel   Add attachments