#4 Default values with spaces in SQL queries fail

v0.1.13
closed-fixed
SQL (14)
7
2005-05-21
2005-04-23
No

ERROR:
The following error occured:

FATAL ERROR: Unable to parse SQL statement; missing
DEFAULT value in field near ['Administrators]

SQL Line:
ALTER TABLE phpbb_themes_name ADD fontcolor5_name CHAR
(50) DEFAULT 'Administrators color'

SUMMARY:
Default values with spaces are incorrectly processed.

LINKS:
http://www.spellingcow.com/phpBB2/viewtopic.php?t=188

FIX:
http://www.spellingcow.com/phpBB2/viewtopic.php?p=1157#1157

Discussion

    • priority: 5 --> 7
     
  • Brendan Kettle
    Brendan Kettle
    2005-04-29

    • status: open --> closed-fixed
     
  • Brendan Kettle
    Brendan Kettle
    2005-04-29

    Logged In: YES
    user_id=1246790

    _should_ be fixed

     
  • Brendan Kettle
    Brendan Kettle
    2005-04-30

    • assigned_to: nobody --> bkettle
     
    • status: closed-fixed --> open
     
  • Logged In: YES
    user_id=779036

    The fix that's currently in CVS does not actually fix the
    problem. For one, it creates an infinite loop. Attached is a
    patch that actually fixes the problem (as well as renaming a
    variable which seemed to be misspelled).

    Still unsupported:
    KEY physical_filename (physical_filename(10))
    KEY attach_id_post_id (attach_id, post_id)

     
  • Brendan Kettle
    Brendan Kettle
    2005-05-01

    Logged In: YES
    user_id=1246790

    Indeed, I was only checking the SQL that breaks it >_<,
    stupid me. Fixed it now, and the typo too.

     
  • Brendan Kettle
    Brendan Kettle
    2005-05-01

    • status: open --> closed
     
  • Brendan Kettle
    Brendan Kettle
    2005-05-01

    • labels: --> SQL
    • status: closed --> closed-fixed
     
    • milestone: --> v0.1.13