Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#5 Eastwood Rewrite

closed-rejected
David Gilbert
None
5
2008-07-18
2008-06-27
David Gilbert
No

This was originally posted by Christophe Blin in the JFreeChart patch tracker:

http://sourceforge.net/tracker/index.php?func=detail&aid=1995094&group_id=15494&atid=315494

Discussion

  • David Gilbert
    David Gilbert
    2008-06-27

    Zip file containing modified sources

     
  • David Gilbert
    David Gilbert
    2008-07-18

    • assigned_to: nobody --> mungady
    • status: open --> closed-rejected
     
  • David Gilbert
    David Gilbert
    2008-07-18

    Logged In: YES
    user_id=112975
    Originator: YES

    I decided not to apply this patch, here are the reasons:

    - the refactoring of the ChartServlet class into a lot of separate classes is a move in the right direction, but don't think it needs that many classes. You'll see in the 1.1.0 release, that there are now three classes (ChartEngine.java, Parameters.java and DataUtilities.java) that handle the chart creation process. I think these classes are manageable.
    - the code uses Java 5 features, but Eastwood is still targetting JRE 1.4.2 and later;
    - the custom axis and plot classes were deliberately kept out of the org.jfree.chart.* namespace, because they're generally hacks just to make some of the Google features work. It probably does make sense to move the plot gradient paint over to JFreeChart, but I don't see a good reason to move the axis stuff over;
    - the included JUnit tests effectively compare bit map images, which is unlikely to be robust from one JRE to another (particularly across operating systems), so I don't think this is a good approach.

    Regards,

    Dave Gilbert
    Eastwood Project Leader