#15 add use base / use parent handling

Unstable (example)
closed-accepted
nobody
None
5
2011-08-26
2011-08-22
Oliver Trosien
No

Currently EPIC does not get the "use base" and "use parent" relation at all.

This patch adds functionality to

- look up "$self->SUPER::subInParent" in ancestors
- look up "$self->method()" locally and ancesors
- show parent in Modules list (outline view) - maybe we'll need to add a special node there?

Discussion

  • Jan Ploski
    Jan Ploski
    2011-08-26

    Applied in CVS, with following corrections:
    - $self->SUPER::subInParent didn't work because it tried finding targetModule SUPER - fixed it in AbstractOpenDeclaration._runWithSearchString
    - reformatted code to match EPIC conventions (esp. braces after new line)

    Enhanced outline view, with a category "Parents" or "Base" would indeed be nice. Are you going to submit or commit another patch to HEAD for that?

    I have one question, too: the modification in SourceFile.updateUseState is not backward compatible in the sense that it now makes "warnings" and "strict" appear as Modules in the outline view. These keywords used to be filtered out. Was this change intentional?

     
  • Jan Ploski
    Jan Ploski
    2011-08-26

    • status: open --> closed-accepted
     
  • Oliver Trosien
    Oliver Trosien
    2011-08-26

    indeed, it was not intended in the first place, but I like having the used pragma in the outline view. It might be worth discussing to not only introduce a category for parents, but also for pragmas. What do you think?

     
  • Jan Ploski
    Jan Ploski
    2011-08-26

    I think it would make sense. Ideally it would be possible to configure the Outline view to select which categories are(n't) displayed, as one might argue that new categories detract from the main "most important" one (subs) shifting it more "below the fold".