Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#36 Inappropriate exception handling - insufficient logging

open
Stephan Ruehl
None
5
2005-02-12
2005-02-01
Jan Ploski
No

The catch(Exception e) clause near the end of
EpicCgiHandler.respond does not provide any clue about
what went wrong. Including stack traces in logged error
messages is a general rule of thumb. Outputting e.getMessage()
is not sufficient (e.getMessage() returns null for any
NullPointerException - not quite helpful to track it down).

I noticed that you have more of such useless catch clauses
spread around the code, so this seems a general QA issue
for EPIC (and many, many other projects, to be fair).
Note that System.out is not appropriate way of logging in
Eclipse plugins, your typical user will not ever see any of
the messages written to System.out.

Discussion

  • Stephan Ruehl
    Stephan Ruehl
    2005-02-12

    Logged In: YES
    user_id=775841

    ... shurely, you are right. If you ask my boss to give me a
    few additional days off I will gladly do the job.

     
  • Stephan Ruehl
    Stephan Ruehl
    2005-02-12

    • labels: 622185 -->