#306 EPIC removes all problem markers for Perl files

v0.5.x
closed-fixed
nobody
Core (65)
5
2006-10-21
2006-09-21
birdo
No

The PerlValidator class periodically (or at least at
startup) removes all problem markers from all Perl files.

If another plugin adds a problem marker to a perl file
for its own purposes it will also be removed. That's
not nice.

Instead, EPIC should define its own marker type that
extends the problem marker type and operate only on it:

Sample plugin.xml code:

<extension id="epicMarker"
name="Perl Problems"
point="org.eclipse.core.resources.markers">
<super
type="org.eclipse.core.resources.textmarker"/>
<super
type="org.eclipse.core.resources.problemmarker"/>
<persistent value="true"/>
</extension>

In addition all references to IMarker.PROBLEM in
PerlValidator should be changed to the new marker id.

Discussion

  • Jan Ploski
    Jan Ploski
    2006-09-25

    Logged In: YES
    user_id=86907

    Can you submit a patch?

     
  • birdo
    birdo
    2006-09-26

    Logged In: YES
    user_id=1092523

    I will submit a patch in the next couple of days.

     
  • birdo
    birdo
    2006-09-26

    Patch for this problem report

     
    Attachments
  • birdo
    birdo
    2006-09-26

    Logged In: YES
    user_id=1092523

    I attached a patch. Notice however that I could not test it,
    since I was unable to build the perleditor project when I
    checked it out from CVS (there are several source files
    missing. Presumably they are generated by Antlr or some such
    but I couldn't figure out where to find them)

     
  • Jan Ploski
    Jan Ploski
    2006-09-28

    Logged In: YES
    user_id=86907

    To get a compilable version, you need the ANTLR plugin, as
    described here: http://e-p-i-c.sourceforge.net/devguide/
    devguide.html

     
  • Jan Ploski
    Jan Ploski
    2006-10-21

    Logged In: YES
    user_id=86907

    Fixed in 0.4.17/0.5.17.

     
  • Jan Ploski
    Jan Ploski
    2006-10-21

    • status: open --> closed-fixed