Re: [PATCH] drm/radeon/kms/rv100: reject modes >135 Mhz on DVI

[Alex D. <ale...@gm...>]

On Mon, Jan 11, 2010 at 1:42 PM, Maarten Maathuis <mad...@gm...> wrote:
> On Mon, Jan 11, 2010 at 6:57 PM, Alex Deucher <ale...@gm...> wrote:
>> >From 6d980869ef031752dac505c1aacbbe221fb2c6e7 Mon Sep 17 00:00:00 2001
>> From: Alex Deucher <ale...@gm...>
>> Date: Mon, 11 Jan 2010 12:39:35 -0500
>> Subject: [PATCH] drm/radeon/kms/rv100: reject modes >135 Mhz on DVI
>>
>> Due to heat issues.  Fixes fdo bug 25992
>>
>> Signed-off-by: Alex Deucher <ale...@gm...>
>> ---
>>  drivers/gpu/drm/radeon/radeon_connectors.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
>> b/drivers/gpu/drm/radeon/radeon_connectors.c
>> index 9da10dd..7ee6515 100644
>> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
>> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
>> @@ -900,11 +900,16 @@ static void radeon_dvi_force(struct
>> drm_connector *connector)
>>  static int radeon_dvi_mode_valid(struct drm_connector *connector,
>>                                  struct drm_display_mode *mode)
>>  {
>> +       struct drm_device *dev = connector->dev;
>> +       struct radeon_device *rdev = dev->dev_private;
>>        struct radeon_connector *radeon_connector = to_radeon_connector(connector);
>>
>>        /* XXX check mode bandwidth */
>>
>>        if (radeon_connector->use_digital && (mode->clock > 165000)) {
>
> Is it just me or is this a check for dual link dvi (which would mean
> the next check is useless)?

Argh.  you're right.  new patch on the way.

>
>> +               /* clocks over 135 MHz have heat issues with DVI on RV100 */
>> +               if ((rdev->family == CHIP_RV100) && (mode->clock > 135000))
>> +                       return MODE_CLOCK_HIGH;
>>                if ((radeon_connector->connector_object_id ==
>> CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
>>                    (radeon_connector->connector_object_id ==
>> CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
>>                    (radeon_connector->connector_object_id ==
>> CONNECTOR_OBJECT_ID_HDMI_TYPE_B))
>> --
>> 1.5.6.3
>>
>> ------------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Verizon Developer Community
>> Take advantage of Verizon's best-in-class app development support
>> A streamlined, 14 day to market process makes app distribution fast and easy
>> Join now and get one step closer to millions of Verizon customers
>> http://p.sf.net/sfu/verizon-dev2dev
>> --
>> _______________________________________________
>> Dri-devel mailing list
>> Dri...@li...
>> https://lists.sourceforge.net/lists/listinfo/dri-devel
>>
>>
>