Re: Bug in i810 agp support?

[Keith W. <ke...@tu...>]

Jon Smirl wrote:
> In i810/server/i810_dri.c there is a call to agp alloc without the
> type set to zero:
> drmAgpAlloc(ctx->drmFD, 4096 * 1024, 1, NULL, &dcacheHandle);
> 
> A type of one translates into U16_APER_SIZE which doesn't match the
> request size of 4MB.
> 
> Is this a bug or do I not understand the type parameter on agp alloc?
> This is the only place where a type other than zero is used.
> 

The i810 had an optional bank of dedicated video ram, the "dcache", 
which was useful for certain tasks despite having lower bandwidth than 
regular shared/system ram.  This memory required special handling - I 
would say the type parameter would have been added for this case in 
particular.

Note that this is not the same as the i810's "stolen" ram which is 
allocated off the top of regular memory at boot time by the bios.

Keith