Re: [R300] drm driver: merge upstream, security, etc

[Eric A. <et...@lc...>]

On Sun, 2005-06-26 at 21:25 -0400, Jon Smirl wrote:
> On 6/26/05, Eric Anholt <et...@lc...> wrote:
> > Are you saying this:
> >         if ((offset>=dev_priv->fb_location) && (offset<dev_priv->gart_vm_start)) return 0;
> > is more readable than:
> >         if ((offset >= dev_priv->fb_location) &&
> >             (offset < dev_priv->gart_vm_start))
> >                 return 0;
> 
> Lindent would do this even with the wrap set at 80 columns.
> if ((offset>=dev_priv->fb_location) && (offset<dev_priv->gart_vm_start)) 
>    return 0;
> 
> This is from the DRM code formatted with an 80 column limit. Lindent
> will let strings exceed 80 columns. To me it look like 13 lines of
> code turned into 28.

Heh.  One of the suggestions of BSD style is that when 80 columns
becomes too little, you probably need another function.  In the diff I'm
currently testing for cleaning up map handling (which net removes 200
lines), I've removed that if statement that didn't need to exist
(afaict), and split the find-the-map bits into another function.  I
think it's quite improved.

-- 
Eric Anholt                                     et...@lc...
http://people.freebsd.org/~anholt/              anholt@FreeBSD.org