From: Vladimir D. <vo...@mi...> - 2005-06-21 20:56:17
|
On Tue, 21 Jun 2005, Eric Anholt wrote: > On Tue, 2005-06-21 at 14:57 -0400, Vladimir Dergachev wrote: >> /* Texture offset is dangerous and needs more checking */ >> ADD_RANGE(R300_TX_OFFSET_0, 16); >> >> I don't think texture offsets are ever written to, however if they >> point in the wrong place they can be used to read memory directly. >> >> ideally we would check these to be either with MC_FB_LOCATION >> or MC_AGP_LOCATION ranges. Problem is what do we do on PCI cards ? >> use AIC controller settings ? > > Just verify that the location is within expected areas of the card's > virtual address space, like you do for color/depth offsets, right? Yes, the question is what these are for PCI cards. I guess AIC should have a register similar to MC_AGP_LOCATION. best Vladimir Dergachev > > -- > Eric Anholt et...@lc... > http://people.freebsd.org/~anholt/ anholt@FreeBSD.org > |