Menu
▾
▴
Re: [Dpp-devel] Review Request: [FIX] Host delete shared project - ID: 3118933
|
From: igel <ig...@in...> - 2011-07-08 09:38:10
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/94/#review227 ----------------------------------------------------------- I tested it with the new patch (v6.1) with three participants. Now the deleted project by one participant will be unshared by all other participants (the shared workspace stays consistent). BUT look at this scenario: - Alice, Bob, and Carl share two projects Test1 and Test2. - Carl deletes Test2 - It might be confusing for Alice and Bob that they don't share Test2 anymore when they won't get informed about that. I don't think that they will check that the sharing icon disappears from the project icon. - Since Alice and Bob didn't know about Carl deleting Test2 from his workspace the might assume they still work on this project together. The other participants need to be informed about unsharing the project (e.g. balloon info). Or when Carl deletes a project he get the option about - deleting this project and leaving the session -> this way Alice and Bob can still work on that project - deleting this project and staying in the session -> Alice and Bob need to be informed - canceling and staying in the session. - igel On July 7, 2011, 11:07 p.m., karlheld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/94/ > ----------------------------------------------------------- > > (Updated July 7, 2011, 11:07 p.m.) > > > Review request for Saros. > > > Summary > ------- > > The deletion of a Project is now transmitted to all session participants. The Session is not ended. Everyone with write-access can delete shared projects. No inconsistencys should appear. > > > This addresses bug 3118933. > http://sourceforge.net/support/tracker.php?aid=3118933 > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/business/AbstractActivityReceiver.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/business/IActivityReceiver.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/business/ProjectActivity.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/activities/serializable/ProjectActivityDataObject.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/editor/EditorManager.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/editor/EditorPool.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/ActivitiesExtensionProvider.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/AbstractSarosSessionListener.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/ISarosSession.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/ISarosSessionListener.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SharedProject.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/ResourceChangeValidator.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/SarosProjectMapper.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/SarosSession.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/serviceProviders/NullSarosSession.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/decorators/SharedProjectDecorator.java 3447 > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/test/stubs/SarosSessionStub.java 3447 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/94/diff > > > Testing > ------- > > manual > > > Thanks, > > karlheld > > |