[Dpp-devel] Review Request: [FIX] (Partial) 3024769 - Java heap space error

[Karl B. <be...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/96/
-----------------------------------------------------------

Review request for Saros.


Summary
-------

Just trying to do my share of bug-fixing...

When adding a large file to a session, after a few seconds an ugly error message informs you of a heap space error. (It depends on your heap size, but with our default size, a >30 MB file should reproduce the error for you.)

The problem is that file data is read into a byte array in one whole step. In my fix, I use the IOUtils to use a buffered read into the byte array instead.

However, this is only a partial fix, because the immediate problem (the heap space error) goes away, but the large file added to the session is not properly added to the peer's copy. (After the addition, the host has the large file in his copy, but not the peer.) 

Try it yourself and look at the logs. Activities get queued up at the peer's side as the host spends time transmitting the data, which eventually gets sent OK. Finally, the peer's log reports that the CreateFileActivity for the large file is ignored, because it does not have the expected sequence number.


Diffs
-----

  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/XMPPTransmitter.java 3447 

Diff: http://saros-build.imp.fu-berlin.de/reviews/r/96/diff


Testing
-------


Thanks,

Karl