From: Christopher Ö. <c.o...@gm...> - 2010-12-26 16:06:28
|
Hi! Michael's solution is correct. Always remember: The local operational transform and the execution in the UI must happen without a possibility for the user to interact in between (this is why we perform them in the SWT-Thread in the first place). +1, but the solution can be simplified, because it is not necessary to maintain the batches as they arrive. Just use putAll to append all incoming events to the queue to execute and then use drainTo to get all currently waiting events and execute them. You should consider opening a dialog though to inform the user if operations are blocking the user too long. Cheers, Christopher On Sat, 25 Dec 2010 21:17:37 +0100, Michael <ju...@in...> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/162/ > ----------------------------------------------------------- > > Review request for All Saros. > > > Summary > ------- > > This patch fixes the broken operational transformation. The problem was > introduced by a new dispatcher in the SarosSession for the SVN > operations. As a consequence a bunch of received activities was not > executed consecutively anymore in the SWT thread and local actions could > be executed in between - milliseconds after the transformation but > before the execution of the transformation. That's why the problem > worsened in case of high load. > > Merry Christmas!!!!! > > [FIX] #3098992 - Inconsistency when concurrently writing at same position > > > Diffs > ----- > > /src/de/fu_berlin/inf/dpp/project/internal/SarosSession.java 2866 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/162/diff > > > Testing > ------- > > > Thanks, > > Michael > > > ------------------------------------------------------------------------------ > Learn how Oracle Real Application Clusters (RAC) One Node allows > customers > to consolidate database storage, standardize their database environment, > and, > should the need arise, upgrade to a full multi-node Oracle RAC database > without downtime or disruption > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Dpp-devel mailing list > Dpp...@li... > https://lists.sourceforge.net/lists/listinfo/dpp-devel -- Herdestr. 10, 12163 Berlin, 01577 195 8758 |