Re: [Dpp-devel] cancellation-wizard-jobs17 - reviewed

[Sandor S. <san...@fu...>]

On 20.10.2009, at 15:21, Tas Sóti wrote:
>>
>> -1, because the constructor used for creating WritableList in
>> InvitationWizardUserSelection#createControl is not compatible with
>> eclipse ganymede. Use List instead of Collection as parameter.
>>
>
> Wow, thanks! I always test with Eclipse 3.5, that's why I have never  
> noticed
> the problem!
>
> Now I've found that I do not need WritableList and data binding at  
> all,
> because the number of entries in the Roster does not change while the
> InvitationWizard is opened (only the presences...). The entries only  
> change
> if a new entry is added or an old one is deleted... if you open the
> InvitationWizard after that, the TableViewer gets the actual list
> (Roster.getEntries()), so it works fine without data binding.
>
> @Sándor: is it working in Eclipse 3.5 now?

You mean version Eclipse 3.4 ;)

> <cancellation-wizard-jobs-23.patch>


+1

Nice work Tas, regards Sandor Szücs
--