This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/279/

Review request for Saros.
By Alexander Waldmann.

Updated March 4, 2012, 9:40 p.m.

Changes

More documentation added, small changes according to Stefans comments

Description

The ResourceSelectionComposite gets an Undo/Redo functionality to avoid frustration when accidentally clicking on a project checkbox after setting a complicated partial sharing selection (thus losing it).

Also includes a Bugfix for the problem that the wizard did not automatically select a newly created project (from within the wizard). The NewProjectListener does not work properly, so i implemented it in another way (probably more efficient also). Also included a nice exception which was never seen because it's only reported in the eclipse error log of the running instance, not in the console of the eclipse that launched the instance.
=> getSelectedResources() returns an abstract collection which does not implement the add() method, so i had to change the way the selection was updated...

The BaseResourceSelectionComposite is now abstract, as it is not intended for direct instantiation anyway. I also wondered if it would make sense to flatten the class hierarchy here, but i guess it's ok to let it remain this way.

Testing

manually

Diffs (updated)

  • trunk/dpp/de.fu_berlin.inf.dpp/icons/etool16/new_project.gif (UNKNOWN)
  • trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/ImageManager.java (3721)
  • trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/widgets/viewer/project/BaseResourceSelectionComposite.java (3721)
  • trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/widgets/viewer/project/ResourceSelectionComposite.java (3721)

View Diff