#771 Deactivate "Add to Saros Session" for read-only users

13.3.15
closed-fixed
3
2013-03-21
2012-09-27
Franz Zieris
No

This results from the fix of #3455399. Since this fix, read-only users are no longer able to add new projects to a running session. But the corresponding entry in the context menu is still active. For a better user experience this entry should be deactivated for read-only users.

Discussion

  • Franz Zieris
    Franz Zieris
    2012-12-19

    • assigned_to: nobody --> pschlott
     
  • I already had a patch, but it (for an unknown) reason only worked with the package view context menu.

    Please keep in mind that you can share files via the Saros Menu and the Session View context menu as well. So please disable them as well.

     
  • I am actually facing the same problem. Disabling the option inside the package view worked without a problem, but for some reason adding the same test to the handler of the Saros Menu and the Saros View did not work.

    The only way i got the "Add to Session" Command to be "deactivated" so far was by replacing it temporally with the Empty Command labeled "Add to Session".

     
  • Using enabledWhen instead of activeWhen seems to have done the trick.

     
    • status: open --> open-fixed
     
  • e7616e14f4627ae33066b3bc08f3543e07792313

     
    • milestone: 12.9.28.TESTING --> 13.3.15
     
    • status: open-fixed --> closed-fixed