#227 command line editing in debugger

Unstable_(example)
closed
None
5
2012-09-07
2010-04-23
etillite
No

I'm not an experienced user of the debugger, so created a patch that adds basic support for command line editing and implements history. It also enables numeric keypad on Windows. Maybe it is useful to anyone else.

There are also other changes in the patch:
- remove unnecessary variable input_count
- set code overview window cursor properly on current instruction
- add log message to F9
- commands INTHAND and C set cursor to first instruction
- some cosmetic changes
- fix some warnings
src/debug/debug.cpp: In member function virtual Bitu DebugPageHandler::readb(PhysPt)': src/debug/debug.cpp:82: warning: no return statement in function returning non-void src/debug/debug.cpp: In member functionvirtual Bitu DebugPageHandler::readw(PhysPt)':
src/debug/debug.cpp:84: warning: no return statement in function returning non-void
src/debug/debug.cpp: In member function virtual Bitu DebugPageHandler::readd(PhysPt)': src/debug/debug.cpp:86: warning: no return statement in function returning non-void src/debug/debug.cpp: In functionvoid LogInstruction(Bit16u, Bit32u, std::ofstream&)':
src/debug/debug.cpp:1905: warning: too many arguments for format
src/debug/debug.cpp: In member function virtual void DEBUG::Run()': src/debug/debug.cpp:1961: warning: unused variable 'ok' src/debug/debug.cpp: In functionvoid SaveMemory(Bitu, Bitu, Bit32u)':
src/debug/debug.cpp:2157: warning: too many arguments for format
src/debug/debug.cpp:2170: warning: too many arguments for format
src/debug/debug.cpp: In function void DrawVariables()': src/debug/debug.cpp:2232: warning: too many arguments for format src/debug/debug.cpp: In functionvoid DEBUG_HeavyLogInstruction()':
src/debug/debug.cpp:2290: warning: unused variable 'size'
src/debug/debug.cpp:2251: warning: 'logCpuCS' defined but not used
src/debug/debug.cpp:2252: warning: 'logCpuEIP' defined but not used

Discussion

  • etillite
    etillite
    2010-05-07

     
    Attachments
  • etillite
    etillite
    2010-05-07

    patch modified

     
  • Peter Veenstra
    Peter Veenstra
    2010-06-05

    Thanks.
    I've commited it.
    Only changed some spacing.