#385 opengl output falls back to surface output in truecolor modes

0.56
open
nobody
None
1
2014-03-18
2012-12-02
No

Symptom: setting windowresolution in dosbox.conf has no effect when running programs in truecolor mode. instead, the window is resized to the program's native resolution.

Analysis: In src/gui/render.cpp, the GFX_RGBONLY flag is set in the gfx flags for truecolor modes. In src/gui/sdlmain.cpp, both GFX_GetBestMode and GFX_SetupSurfaceScaled check that flag for the 'opengl' output, and refuse to use it when the flag is set. Removing these two checks makes the problem disappear. (They appear to be a copy of checks for the 'overlay' output, which I believe works in YUV colorspace.)

Additional information: I'm using dosbox in windowed mode under Linux

Discussion

  • Oops, I meant to change the milestone. Dosbox version is 0.74.

     
  • I'm also using Dosbox 0.74 on Linux and see this behavior as well. Changing windowresolution has no effect. The result is an annoyingly small window on my 1440x900 screen.

     
  • Maks Verver
    Maks Verver
    2014-03-18

    This affects fullscreen mode too, not just windowed mode, and like Brandon says, this is very annoying on Linux because it means there is not a single output that supports scaling in RGB modes.

    Attached is a simple patch following Bertram's suggestion, which does seem to fix the problem.

     
    Attachments