Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#343 please remove non-free fmopl files from tarball

SVN
closed
None
7
2012-11-28
2009-11-29
Jan Dittberner
No

Wei Mingzhi reported the bug #530824 (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530824) in the Debian bug tracker. This release critical bug mentions that the file src/hardware/fmopl.c seems to be based on the MAME version released under a non-free license. Since DOSBox 0.73 contains a new GPLed OPL emulation and builds fine without fmopl it would be great if you would remove src/hardware/fmopl.c and src/hardware/fmopl.h to allow the legal distribution of the unmodified DOSBox tarball in Debian releases and derivatives (i.e Ubuntu).

Discussion

  • Jan Dittberner
    Jan Dittberner
    2009-11-29

    remove remaining fmopl dependencies

     
  • Jan Dittberner
    Jan Dittberner
    2009-11-29

    the attached patch removes the remaining fmopl dependency from adlib.cpp

     
  • Peter Veenstra
    Peter Veenstra
    2009-12-03

    A few weeks ago the opl emulator section was cleaned up doing the same as you did.
    compat and fast are only 2 opl emulators in the SVN and the next release will be shipped as such.

    here is the svn revision
    r3490 | qbix79 | 2009-11-03 21:17:42 +0100 (Tue, 03 Nov 2009) | 2 lines
    Changed paths:
    M /dosbox/trunk/src/dosbox.cpp
    M /dosbox/trunk/src/hardware/Makefile.am
    M /dosbox/trunk/src/hardware/adlib.cpp
    D /dosbox/trunk/src/hardware/fmopl.c
    D /dosbox/trunk/src/hardware/fmopl.h
    D /dosbox/trunk/src/hardware/ymf262.c
    D /dosbox/trunk/src/hardware/ymf262.h

    Remove old opl.

    You might want to compare it against your own as this commit is more complete.

     
  • Peter Veenstra
    Peter Veenstra
    2012-01-25

    Closing as 0.74 has been out for a while.
    Sorry to keep it open while the matter was actually resolved.