Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#318 Various small bugs

open
None
5
2012-09-07
2008-10-30
etillite
No

I think have found some very small bugs and typos in dosbox cvs.
Patch is attached.

  1. Illegal/Unhandled opcode log message displays random garbage if core=simple.

  2. DosBox uses stdaux as alias for com1. Real dos uses device aux.

  3. The displayed error message contains `"%s"' instead of the wrong parameter if the image format
    is invalid in imgmount command.

  4. Missing info for fat drive in mount list.

  5. Under Windows XP using windib driver left and right control, left and right alt, printscreen and keypad-* keys
    are the same if usescancodes=true.

  6. Bios video mode 0xA uses 40 columns instead of 80 ones.

  7. Missing braces in INT10_SetVideoMode() at disabling MMIO.

  8. Parsing error in IF command. The result of comparison "word"=="word" is always false because first string
    is parsed as "word"' the second one asword' (without quotation marks).
    It breaks Blockout's install batch file when no drive is specified.
    Affected code snippet:
    set DRIVE=%1
    if not "%1"=="" goto :copy
    set DRIVE=c:
    :copy
    md %DRIVE%blockout

Discussion

  • etillite
    etillite
    2008-10-30

     
    Attachments
  • Peter Veenstra
    Peter Veenstra
    2008-11-01

    I have to check that STDAUX vs AUX
    The 0xa mode I have to check against the tables I have.

    The if stuff. I would have to check that as well. Maybe StripWord is broken ?

     
  • Peter Veenstra
    Peter Veenstra
    2008-11-01

    never mind that point of mine of number 8
    Using stripword is wrong there as there can't be spaces in the if "string"

     
  • etillite
    etillite
    2008-11-06

    Small info for device aux: I saw the device drivers list in msd.exe under ms-dos. There are com1-4 and aux, no stdaux. And created successfully file stdaux.

    if stuff: attached a new patch. Think it make the command more compatible with ms-dos.

     
  • c2woody
    c2woody
    2008-11-18

    6,7 and 5 have been checked and committed.

    Thanks for pointing these out!

     
  • etillite
    etillite
    2009-01-12

    misleading comment removed

     
    Attachments
  • etillite
    etillite
    2010-03-12

    2 and 8 was fixed in v0.73.

    Maybe item 3 will be fixed in next release?

     
  • Peter Veenstra
    Peter Veenstra
    2010-03-13

    fixed number 3