#176 FFREE NPX op doesn't work

0.61
closed
None
5
2012-09-07
2004-03-31
Tony Ingenoso
No

finit
fld1
fld1
fld1
fld1
fld1
fld1
fld1
fld1
ffree st(0)
ffree st(1)
ffree st(2)
ffree st(3)
ffree st(4)
ffree st(5)
ffree st(6)
ffree st(7)

Examine tag word contents. The whole tag word should
be back to xFFFF at this point, but its not, none of the
tags are marked free.

Discussion

  • Peter Veenstra
    Peter Veenstra
    2004-03-31

    Logged In: YES
    user_id=535630

    I'll look at it.
    Although I'm not sure if we use tags at all :)
    I think we hope that the program knows which registers it
    filled :)

    Thank you for reporting it.

     
  • Peter Veenstra
    Peter Veenstra
    2004-03-31

    Logged In: YES
    user_id=535630

    Ps This is the right location for reporting bugs.
    The reports you made at vogons are usefull, but some people
    got upset in the way you reported them (like in. it's a
    miracle that something runs in dosbox at all as this bug is
    present)

    Just report them more neutral (so no badly broken...)
    or report them here.
    I allready looked into the keyboard bugs. Very handy file
    you supplied!

    Please keep up the good work
    If you mention your vogons nick here I'll activate it
    without the email thing.

     
  • Tony Ingenoso
    Tony Ingenoso
    2004-03-31

    Logged In: YES
    user_id=998201

    I looked at the CVS source and there does appear to be an
    attempt to maintain the tags. There IS some code claiming
    to set them to empty for FFREE as well. This has to be some
    issue that's upstream of the actual FFREE code, which was
    quite small/trivial.

     
  • Peter Veenstra
    Peter Veenstra
    2004-03-31

    Logged In: YES
    user_id=535630

    the ffree is supported.
    it's the saving of the status word which is unsupported.
    with either fstenv
    or fsave
    Both aren't supported.
    I didn't implement those as they looked a bit unneeded and
    their implementation was depended on the supplied register.
    (16 or 32 bit)

     
  • Peter Veenstra
    Peter Veenstra
    2004-03-31

    new fpu-files

     
    Attachments
  • Peter Veenstra
    Peter Veenstra
    2004-03-31

    Logged In: YES
    user_id=535630

    I've attached new fpu files.
    Those implement FSTENV FLDENV FSAVE FSTOR

    Hmm now I release I'm not certain if you can recompile
    dosbox....

    Could you provide a binary of that free.asm ?
    Then I'll see if it works
    Or if you can recompile dosbox...
    use this archive in src/fpu

     
  • Tony Ingenoso
    Tony Ingenoso
    2004-03-31

    FFREE.EXE (bound FAPI executable, runs DOS, OS/2, or NT)

     
    Attachments
  • Tony Ingenoso
    Tony Ingenoso
    2004-03-31

    Logged In: YES
    user_id=998201

    I've updated the FFREE test to be more complete in triaging
    any discrepancies it runs across. The test EXE I uploaded
    has these enhancements built into it. It'll now distinguish
    which tag (if any) is bad, as well as printing out the bad tag
    values.

     
  • Tony Ingenoso
    Tony Ingenoso
    2004-03-31

    Updated FFREE.ASM

     
    Attachments
  • Peter Veenstra
    Peter Veenstra
    2004-04-01

    Logged In: YES
    user_id=535630

    Okay. I made a little mistake in my implementation.
    ( I saved the 8 registers to the interrupt table ;)
    but futher it worked fine.

    Closing this report and marking it as fixed.
    Feel free to reopen it if it's still wrong somehow.